bpo-46857: Fix refleak in OSError INIT_ALIAS() #31594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_Py_GetRefTotal() no longer decrements _PySet_Dummy refcount.
jkloth
approved these changes
Feb 26, 2022
Contributor
jkloth
left a comment
jkloth
left a comment
There was a problem hiding this comment.
Seems to work, although do not forget to test with buildbots!
| total -= Py_REFCNT(o); | ||
| return total; | ||
| return _Py_RefTotal; | ||
| } |
Contributor
There was a problem hiding this comment.
If this is no longer needed, more the better, but I haven't been testing this change
Contributor
There was a problem hiding this comment.
Ah, this is the change that makes total refs 0!
Member
Author
There was a problem hiding this comment.
Ah, this is the change that makes total refs 0!
Without this change, _Py_GetRefTotal() returns -2 when the Python process is started, before calling Py_Initialiaze() (ex: if you put a breakpoint on the main() function).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Py_GetRefTotal() no longer decrements _PySet_Dummy refcount.
https://bugs.python.org/issue46857