bpo-43253: don't shutdown invalid socket handles #31892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If you merge/rebase |
On Windows on the ProactorEventLoop, there are situations where `fileno()` returns -1 during socket close, in which case calling `shutdown()` would raise an OSError. Avoid that by explicitly checking `fileno()`.
Contributor
Author
|
Thanks for the heads-up, @hugovk! 🍰 |
asvetlov
approved these changes
Mar 15, 2022
Contributor
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 15, 2022
…-31892) (cherry picked from commit 7015541) Co-authored-by: Maximilian Hils <[email protected]>
|
GH-31905 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 15, 2022
…-31892) (cherry picked from commit 7015541) Co-authored-by: Maximilian Hils <[email protected]>
|
GH-31906 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 15, 2022
(cherry picked from commit 7015541) Co-authored-by: Maximilian Hils <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Mar 15, 2022
(cherry picked from commit 7015541) Co-authored-by: Maximilian Hils <[email protected]>
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…-31892) (cherry picked from commit 7015541) Co-authored-by: Maximilian Hils <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows on the ProactorEventLoop, there are situations where
fileno()returns -1 during socket close, in which case callingshutdown()would raise an OSError. Avoid that by explicitly checkingfileno().https://bugs.python.org/issue43253