bpo-46712: Do not Regen Deep-Frozen Modules before Generating Global Objects #32061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
added a commit
that referenced
this pull request
Mar 28, 2022
…gen-global-objects. (gh-32162) The race likely originated with gh-32061. https://bugs.python.org/issue47146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to run regen-deepfreeze before running Tools/scripts/generate-global-objects.py; otherwise we will miss any changes to global objects in deep-frozen modules (which aren't committed in the repo). However, building
$(PYTHON_FOR_FREEZE)fails if one of its source files had a global object added or removed, without generate-global-objects.py running first. Somake regen-global-objectswould sometimes fail.We solve this by running generate-global-objects.py before and after regen-deepfreeze. To speed things up and cut down on noise, we also avoid updating the global objects files if there are no changes.
https://bugs.python.org/issue46712