bpo-46480: rephrase typing.assert_type docs #32069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is to reduce potential confusion between `assert_type(val, type)` and `assert isinstance(val, typ)`. The former is meant to ask a type checker to confirm a fact, the latter is meant to tell a type checker a fact. The behaviour of the latter more closely resembles what I'd expect from the prior phrasing of "assert [something] to the type checker".
hauntsaninja
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
Contributor
Author
|
(We can skip-news, since this is just docs for a new feature. This was originally brought up at python/typing#1103 ) |
AlexWaygood
approved these changes
Mar 23, 2022
JelleZijlstra
approved these changes
Mar 24, 2022
hauntsaninja
added a commit
to hauntsaninja/cpython
that referenced
this pull request
Apr 29, 2022
This change is similar to that in python#32069
JelleZijlstra
pushed a commit
that referenced
this pull request
Apr 30, 2022
This change is similar to that in #32069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to reduce potential confusion between
assert_type(val, typ)andassert isinstance(val, typ).The former is meant to ask a type checker to confirm a fact, the latter
is meant to tell a type checker a fact. The behaviour of the latter more
closely resembles what I'd expect from the previous phrasing of
"assert [something] to the type checker".
https://bugs.python.org/issue46480