gh-91266: refactor bytearray strip methods #32096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eendebakpt
force-pushed
the
refactor/bytearray_strip
branch
from
1a70230 to
755c495
Compare
MaxwellDupre
approved these changes
Mar 25, 2022
Contributor
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Test Results:
415 tests OK.
8 tests failed:
test_asyncio test_bdb test_distutils test_embed test_idle
test_ossaudiodev test_peg_generator test_venv
Looks like none relevant.
Member
|
The Python-visible API probably shouldn't change. |
Contributor
Author
|
@sweeneyde Can you review again? Thanks |
sweeneyde
approved these changes
Apr 9, 2022
Member
sweeneyde
left a comment
sweeneyde
left a comment
There was a problem hiding this comment.
We should typically be pretty conservative about refactoring PRs, but since this eliminates 45 lines, I think it makes sense.
Contributor
|
@sweeneyde Thanks. Should I add a new entry for this? |
Member
|
Sure, yes: better to err on the side of documenting everything. |
eendebakpt
changed the title
sweeneyde
reviewed
Apr 13, 2022
Misc/NEWS.d/next/Core and Builtins/2022-04-13-07-14-30.gh-issue-91266.6Vkzzt.rst
Outdated
Show resolved
Hide resolved
…e-91266.6Vkzzt.rst Co-authored-by: Dennis Sweeney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bytearray strip, lstrip and rstrip methods contain duplicated code. This PR refactors the three implementations to use common code.
https://bugs.python.org/issue47110