bpo-31294: Fix ZeroMQSocketListener and ZeroMQSocketHandler examples

[pablogsal]

This PR fixes two documentation issues regarding the ZeroMQSocketListener and ZeroMQSocketHandler examples in the Logging Cookbook:

• The first issue is that in the __ init__ method for the ZeroMQSocketListener the base class __ init__ is never called and therefore the internal variables are not correctly initialized. This leads to an empty handlers attribute and a undefined queue attribute.

• The second issue is that zmq.Socket.send and zmq.Socket.setsockopt only admits bytecode variables and therefore it fails in Python3 when using plain strings. The fix is to use zmq.Socket.send_stringand mq.Socket.setsockopt_string instead.

https://bugs.python.org/issue31294

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

[tiran]

Thanks for your contribution, @pablogsal

• Please add a News entry with the blurb tool
• Instead of json.dumps + send_string(), how about send_json() instead? https://pyzmq.readthedocs.io/en/latest/api/zmq.html#zmq.Socket.send_json

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[pablogsal]

I didn't expect the Spanish Inquisition!

[bedevere-bot]

Nobody expects the Spanish Inquisition!

@tiran: please review the changes made to this pull request.

[tiran]

Thanks, good work 🥇

[miss-islington]

🐍🍒⛏🤖 Thanks @pablogsal for the PR, and @tiran for merging it 🌮🎉.I'm working now to backport this PR to: 3.6.

[bedevere-bot]

GH-3430 is a backport of this pull request to the 3.6 branch.