bpo-31308: If multiprocessing's forkserver dies, launch it again when necessary #3246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
TODO: investigate what happens with previously-launched processes. Edit: done. |
…race condition in test_many_processes.
…nto detect_forkserver_death
Member
Author
|
@applio, I'm planning to merge this soon. |
gst
reviewed
Sep 8, 2017
|
|
||
| proc.join() | ||
| self.assertTrue(evt.is_set()) | ||
| self.assertIn(proc.exitcode, (0, 255)) |
Contributor
There was a problem hiding this comment.
Hi,
I don't see/get where you assert that a new process is started.. something like :
new_pid = _forkserver._forkserver_pid # EDIT removed typo assert
assert new_pid is not None and pid != new_pid
or did I miss something ?
Regards.
Member
Author
There was a problem hiding this comment.
Indeed I don't. I'm not sure it's important, though, since what matters is that the Process API continues working properly.
Contributor
There was a problem hiding this comment.
True. self.Process(..) does that indeed.
Member
|
Added comments on the issue tracker (at https://bugs.python.org/issue31308). In short, I like the idea but I think we need to be more explicit about what we ask the forkserver to do. |
pitrou
added a commit
to pitrou/cpython
that referenced
this pull request
Nov 3, 2017
…n when necessary (pythonGH-3246) * bpo-31308: If multiprocessing's forkserver dies, launch it again when necessary. * Fix test on Windows * Add NEWS entry * Adopt a different approach: ignore SIGINT and SIGTERM, as in semaphore tracker. * Fix comment * Make sure the test doesn't muck with process state * Also test previously-started processes * Update 2017-08-30-17-59-36.bpo-31308.KbexyC.rst * Avoid masking SIGTERM in forkserver. It's not necessary and causes a race condition in test_many_processes.. (cherry picked from commit fc6b348)
pitrou
added a commit
that referenced
this pull request
Nov 3, 2017
…n when necessary (GH-3246) (#4252) * bpo-31308: If multiprocessing's forkserver dies, launch it again when necessary. * Fix test on Windows * Add NEWS entry * Adopt a different approach: ignore SIGINT and SIGTERM, as in semaphore tracker. * Fix comment * Make sure the test doesn't muck with process state * Also test previously-started processes * Update 2017-08-30-17-59-36.bpo-31308.KbexyC.rst * Avoid masking SIGTERM in forkserver. It's not necessary and causes a race condition in test_many_processes.. (cherry picked from commit fc6b348)
embray
pushed a commit
to embray/cpython
that referenced
this pull request
Nov 9, 2017
… necessary (python#3246) * bpo-31308: If multiprocessing's forkserver dies, launch it again when necessary. * Fix test on Windows * Add NEWS entry * Adopt a different approach: ignore SIGINT and SIGTERM, as in semaphore tracker. * Fix comment * Make sure the test doesn't muck with process state * Also test previously-started processes * Update 2017-08-30-17-59-36.bpo-31308.KbexyC.rst * Avoid masking SIGTERM in forkserver. It's not necessary and causes a race condition in test_many_processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31308