Skip to content

[2.7] bpo-30450: Don't use where, it doesn't exist on XP #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zware merged 1 commit into from
Sep 5, 2017
Merged

[2.7] bpo-30450: Don't use where, it doesn't exist on XP #3330

zware merged 1 commit into from
Sep 5, 2017

Conversation

@zware
Copy link
Member

@zware zware commented Sep 4, 2017 •
edited by bedevere-bot
Loading

@zware zware requested a review from zooba September 4, 2017 23:38
@vstinner vstinner changed the title Don't use where, it doesn't exist on XP [2.7] Don't use where, it doesn't exist on XP Sep 5, 2017
vstinner
vstinner approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even if I don't know Windows error codes :-)

@zooba
Copy link
Member

zooba commented Sep 5, 2017

Do builds on XP even work? I thought we supported it as a target, but not a build OS.

@vstinner vstinner changed the title [2.7] Don't use where, it doesn't exist on XP [2.7] bpo-30450: Don't use where, it doesn't exist on XP Sep 5, 2017
@vstinner
Copy link
Member

vstinner commented Sep 5, 2017

Don't skip the issue, if there is an issue :-) https://bugs.python.org/issue30450

@zware
Copy link
Member Author

zware commented Sep 5, 2017

@zooba http://buildbot.python.org/all/builders/x86%20Windows%20XP%202.7/builds/276

@zware zware merged commit aa23144 into python:2.7 Sep 5, 2017
@zware zware deleted the xp_you_annoy_me branch September 5, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@zooba zooba zooba approved these changes

Assignees

No one assigned

Labels

OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zware @zooba @vstinner @Mariatta @the-knights-who-say-ni @bedevere-bot