[3.4][Security] bpo-29572: Update Windows build to OpenSSL 1.0.2k (GH-443) #3445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
changed the title
Member
Author
|
Please review carefully this cherry-pick since I had conflicts on the backport. Original change: commit dd2000c. |
tiran
approved these changes
Sep 8, 2017
zware
approved these changes
Sep 8, 2017
Member
zware
left a comment
zware
left a comment
There was a problem hiding this comment.
Approved, as long as AppVeyor also approves :)
Member
Author
|
Similar change for macOS: PR #3447. |
vstinner
changed the title
Contributor
|
I don't understand how this branch is out-of-date with 3.4...? I haven't accepted any patches into the 3.4 branch in a while. Anyway, please update the PR so that I get a nice green accept button instead of an angry red "Squash And Merge" button. I don't like pressing red buttons. |
Member
Author
|
I rebased my PR on top of the current 3.4 branch. |
Member
Author
|
@larryhastings: Is it better now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit dd2000c)
https://bugs.python.org/issue29572