bpo-31400: Improve SSL error handling on Windows #3463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
added
needs backport to 3.6
OS-windows
sprint
type-bug
tiran
reviewed
Sep 8, 2017
| @@ -0,0 +1 @@ | |||
| Improves SSL error handling on Windows to avoid losing error numbers. | |||
tiran
approved these changes
Sep 8, 2017
Member
tiran
left a comment
tiran
left a comment
There was a problem hiding this comment.
LGTM
Please address the minor nit pick in Mews/NEWS.d.
Contributor
Contributor
|
Sorry, @zooba and @tiran, I could not cleanly backport this to |
|
GH-3466 is a backport of this pull request to the 3.6 branch. |
tiran
pushed a commit
to tiran/cpython
that referenced
this pull request
Sep 8, 2017
* bpo-31392: Improve SSL error handling on Windows * Remove unnecessary Windows mention in NEWS. (cherry picked from commit e6eb48c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31400