Skip to content

bpo-31373: remove overly strict float range checks #3486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjaminp merged 1 commit into from
Sep 11, 2017
Merged

bpo-31373: remove overly strict float range checks #3486

benjaminp merged 1 commit into from
Sep 11, 2017

Conversation

@benjaminp
Copy link
Contributor

@benjaminp benjaminp commented Sep 10, 2017 •
edited by bedevere-bot
Loading

This undoes a853a8b except for the pytime.c
parts. We want to continue to allow IEEE 754 doubles larger than FLT_MAX to be
rounded into finite floats. Tests were added to very this behavior.

https://bugs.python.org/issue31373

@benjaminp
bpo-31373: remove overly strict float range checks
b0b137e 
This undoes a853a8b except for the pytime.c
parts. We want to continue to allow IEEE 754 doubles larger than FLT_MAX to be
rounded into finite floats. Tests were added to very this behavior.
mdickinson
mdickinson approved these changes Sep 10, 2017
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminp benjaminp merged commit 2bb69a5 into master Sep 11, 2017
benjaminp added a commit that referenced this pull request Sep 11, 2017
@benjaminp
[3.6] bpo-31373: remove overly strict float range checks (GH-3486)
1966dec 
This undoes a853a8b except for the pytime.c
parts. We want to continue to allow IEEE 754 doubles larger than FLT_MAX to be
rounded into finite floats. Tests were added to very this behavior.
(cherry picked from commit 2bb69a5)
@benjaminp benjaminp deleted the benjamin-float-rounding branch September 12, 2017 06:08
benjaminp added a commit that referenced this pull request Sep 12, 2017
@benjaminp
[3.6] bpo-31373: remove overly strict float range checks (GH-3486) (#…
cb356c2 
…3495)

This undoes a853a8b except for the pytime.c
parts. We want to continue to allow IEEE 754 doubles larger than FLT_MAX to be
rounded into finite floats. Tests were added to very this behavior.
(cherry picked from commit 2bb69a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdickinson mdickinson mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@benjaminp @mdickinson @Mariatta @the-knights-who-say-ni @bedevere-bot