Skip to content

bpo-31249: Fix test_concurrent_futures dangling thread #3521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Sep 13, 2017
Merged

bpo-31249: Fix test_concurrent_futures dangling thread #3521

vstinner merged 1 commit into from
Sep 13, 2017

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 12, 2017 •
edited by bedevere-bot
Loading

ProcessPoolShutdownTest.test_del_shutdown() now closes the call queue
and joins its thread, to prevent leaking a dangling thread.

https://bugs.python.org/issue31249

@vstinner
bpo-31249: Fix test_concurrent_futures dangling thread
5a32032 
ProcessPoolShutdownTest.test_del_shutdown() now closes the call queue
and joins its thread, to prevent leaking a dangling thread.
@vstinner vstinner merged commit 3bcf157 into python:master Sep 13, 2017
@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2017

Thanks, @Haypo!

@vstinner vstinner deleted the call_queue branch September 13, 2017 00:05
@miss-islington
Copy link
Contributor

miss-islington commented Sep 13, 2017

Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2017
@vstinner @miss-islington
[3.6] bpo-31249: Fix test_concurrent_futures dangling thread (pythonG…
06baad9 
…H-3521)

ProcessPoolShutdownTest.test_del_shutdown() now closes the call queue
and joins its thread, to prevent leaking a dangling thread.
(cherry picked from commit 3bcf157)
@bedevere-bot
Copy link

bedevere-bot commented Sep 13, 2017

GH-3522 is a backport of this pull request to the 3.6 branch.

vstinner pushed a commit that referenced this pull request Sep 13, 2017
@miss-islington @vstinner
[3.6] bpo-31249: Fix test_concurrent_futures dangling thread (GH-3521) (
94eb2d5 
#3522)

ProcessPoolShutdownTest.test_del_shutdown() now closes the call queue
and joins its thread, to prevent leaking a dangling thread.
(cherry picked from commit 3bcf157)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni