Skip to content

[3.6] bpo-31234: Join threads in tests #3589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 5 commits into from
Sep 15, 2017
Merged

[3.6] bpo-31234: Join threads in tests #3589

vstinner merged 5 commits into from
Sep 15, 2017

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 14, 2017 •
edited by bedevere-bot
Loading

@vstinner
Copy link
Member Author

vstinner commented Sep 15, 2017

Hum, it may be interesting to also backport the PR #3598 (join timers).

@vstinner
bpo-31234: Join threads in tests (#3572)
f49240b 
Call thread.join() on threads to prevent the "dangling threads"
warning.

(cherry picked from commit 18e95b4)
@vstinner
bpo-31234: Join threads in test_hashlib (#3573)
bf96cfc 
* bpo-31234: Join threads in test_hashlib

Use thread.join() to wait until the parallel hash tasks complete
rather than using events. Calling thread.join() prevent "dangling
thread" warnings.

* test_hashlib: minor PEP 8 coding style fixes

(cherry picked from commit 8dcf22f)
@vstinner
bpo-31234: Join threads in test_threading (#3579)
9dcd888 
Call thread.join() to prevent the "dangling thread" warning.

(cherry picked from commit b8c7be2)
@vstinner
bpo-31234: Join threads in test_queue (#3586)
d4006ee 
Call thread.join() to prevent the "dangling thread" warning.

(cherry picked from commit 167cbde)
@vstinner
bpo-31234: Join timers in test_threading (#3598)
599a22d 
Call the .join() method of threading.Timer timers to prevent the
"threading_cleanup() failed to cleanup 1 threads" warning.

(cherry picked from commit da3e5cf)
@vstinner
Copy link
Member Author

vstinner commented Sep 15, 2017

Hum, it may be interesting to also backport the PR #3598 (join timers).

Done. I also rebased my PR.

@vstinner vstinner merged commit 2c1c2ca into python:3.6 Sep 15, 2017
@vstinner vstinner deleted the thread36 branch September 15, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @Mariatta @the-knights-who-say-ni @bedevere-bot