bpo-31492: Fix assertion failures in case of a module with a bad __name__ attribute #3620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
approved these changes
Sep 19, 2017
Contributor
|
Thanks @orenmn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Contributor
|
Sorry, @orenmn and @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
pushed a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 26, 2017
…d __name__ attribute. (pythonGH-3620). (cherry picked from commit 6db7033)
|
GH-3773 is a backport of this pull request to the 3.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moduleobject.c: add a check whether the retrieved__name__attribute is a string. while we are here, remove a redundant call toPyErr_Clear().ceval.c: add a check whether the retrieved__name__attribute is not a string.test_import/__init__.py: add a test to verify that the assertion failures are no more.https://bugs.python.org/issue31492