-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-27319, bpo-31508: Document deprecation in Treeview.selection(). #3667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-27319, bpo-31508: Document deprecation in Treeview.selection(). #3667
Conversation
Defer removing old behavior to 3.8. Document new feature of selection_set() and friends.
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It's up to you to apply this one or PR #3651.
|
@terryjreedy, could you please make a review of the documentation changes? I don't think documenting this in the "What's New" document is required. This is minor change. And I hope nobody uses |
Doc/library/tkinter.ttk.rst
Outdated
| *items* becomes the new selection. | ||
|
|
||
| .. versionchanged:: 3.6 | ||
| *items* can be passeed as separate arguments, not just as a single tuple. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passed with a single E
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
|
|
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-3719 is a backport of this pull request to the 3.6 branch. |
…n(). (pythonGH-3667) Defer removing old behavior to 3.8. Document new feature of selection_set() and friends. (cherry picked from commit 2fad102)
Defer removing old behavior to 3.8.
Document new feature of selection_set() and friends.
https://bugs.python.org/issue27319