Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 20, 2017

Defer removing old behavior to 3.8.
Document new feature of selection_set() and friends.

https://bugs.python.org/issue27319

Defer removing old behavior to 3.8.
Document new feature of selection_set() and friends.
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It's up to you to apply this one or PR #3651.

@serhiy-storchaka
Copy link
Member Author

@terryjreedy, could you please make a review of the documentation changes?

I don't think documenting this in the "What's New" document is required. This is minor change. And I hope nobody uses selection('add', items) instead of selection_add(items).

*items* becomes the new selection.

.. versionchanged:: 3.6
*items* can be passeed as separate arguments, not just as a single tuple.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed with a single E

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@terryjreedy
Copy link
Member

Items being either singular or plural is slightly awkward. I would leave what you have as is. Martin knows the markup better than I. I would push this now and #3651 after 3.7 is branched off after the beta.

@serhiy-storchaka serhiy-storchaka merged commit 2fad102 into python:master Sep 24, 2017
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the treeview-selection-deprecate branch September 24, 2017 11:34
@bedevere-bot
Copy link

GH-3719 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2017
…n(). (pythonGH-3667)

Defer removing old behavior to 3.8.
Document new feature of selection_set() and friends.
(cherry picked from commit 2fad102)
serhiy-storchaka pushed a commit that referenced this pull request Sep 24, 2017
…n(). (GH-3667) (#3719)

Defer removing old behavior to 3.8.
Document new feature of selection_set() and friends.
(cherry picked from commit 2fad102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants