bpo-31536: Avoid wholesale rebuild after make regen-all
#3678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Sep 20, 2017
| $(srcdir)/Lib/importlib/_bootstrap.py \ | ||
| $(srcdir)/Python/importlib.h | ||
| $(srcdir)/Python/importlib.h.new | ||
| $(UPDATE_FILE) $(srcdir)/Python/importlib.h $(srcdir)/Python/importlib.h.new |
Member
There was a problem hiding this comment.
It's a little bit boring to always have to repeat the full path. Why not passing a single parameter to the update script, and add ".new" to get the "new filename"?
Member
Author
There was a problem hiding this comment.
Because it doesn't impose a naming convention and makes it explicit which files are operated on. Also, there's a lot of boredom in Makefiles ;-)
Member
There was a problem hiding this comment.
Ok. It was just a suggestion, being explicit is fine.
Also, there's a lot of boredom in Makefiles ;-)
I will not start discussing that aspect of Makefiles, thanks.
Member
Author
|
Thank you Victor! |
Contributor
|
GH-3797 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 28, 2017
…onGH-3678) * bpo-31536: Avoid wholesale rebuild after `make regen-all` * Add NEWS (cherry picked from commit b091bec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue31536