bpo-31459: Rename IDLE's module browser from Class Browser to Module Browser. #3704
Conversation
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
Revert config-keys.cfg compatibility break.
Lib/idlelib/config-keys.def
Outdated
| view-restart=<Key-F6> | ||
| restart-shell=<Control-Key-F6> | ||
| open-class-browser=<Alt-Key-c> <Meta-Key-c> <Alt-Key-C> <Meta-Key-C> | ||
| open-module-browser=<Alt-Key-c> <Meta-Key-c> <Alt-Key-C> <Meta-Key-C> |
There was a problem hiding this comment.
Changing the virtual event name breaks compatibility existing user customizations. I don't want to do that, certainly not yet. So revert all in this file.
Lib/idlelib/config.py
Outdated
| '<<view-restart>>': ['<F6>'], | ||
| '<<restart-shell>>': ['<Control-F6>'], | ||
| '<<open-class-browser>>': ['<Alt-c>'], | ||
| '<<open-module-browser>>': ['<Alt-c>'], |
Lib/idlelib/editor.py
Outdated
| text.bind("<<open-new-window>>", self.new_callback) | ||
| text.bind("<<close-all-windows>>", self.flist.close_all_callback) | ||
| text.bind("<<open-class-browser>>", self.open_class_browser) | ||
| text.bind("<<open-module-browser>>", self.open_module_browser) |
There was a problem hiding this comment.
And here (just the <<open...>> part.
Lib/idlelib/mainmenu.py
Outdated
| ('_Open...', '<<open-window-from-file>>'), | ||
| ('Open _Module...', '<<open-module>>'), | ||
| ('Class _Browser', '<<open-class-browser>>'), | ||
| ('Module _Browser', '<<open-module-browser>>'), |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I didn't expect the Spanish Inquisition! |
|
Nobody expects the Spanish Inquisition! @terryjreedy: please review the changes made to this pull request. |
|
To test, I used both the menu and hot key in Shell with file already open or not, and then both menu and hot key in editor. |
terryjreedy
changed the title
terryjreedy
changed the title
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-3710 is a backport of this pull request to the 3.6 branch. |
…odule Browser. (pythonGH-3704) The original module-level class and method browser became a module browser, with the addition of module-level functions, years ago. Nested classes and functions were added yesterday. For back- compatibility, the virtual event <<open-class-browser>>, which appears on the Keys tab of the Settings dialog, is not changed. Patch by Cheryl Sabella. (cherry picked from commit cd99e79)
…odule Browser. (GH-3704) (#3710) The original module-level class and method browser became a module browser, with the addition of module-level functions, years ago. Nested classes and functions were added yesterday. For back- compatibility, the virtual event <<open-class-browser>>, which appears on the Keys tab of the Settings dialog, is not changed. Patch by Cheryl Sabella. (cherry picked from commit cd99e79)
6 participants
https://bugs.python.org/issue31459