Skip to content

bpo-31627: Make test_mailbox be lenient to empty hostname. #3821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Sep 30, 2017
Merged

bpo-31627: Make test_mailbox be lenient to empty hostname. #3821

serhiy-storchaka merged 1 commit into from
Sep 30, 2017

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 29, 2017 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka requested a review from a team as a code owner September 29, 2017 13:28
warsaw
warsaw reviewed Sep 29, 2017
View reviewed changes
Copy link
Member

@warsaw warsaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @bitdancer in bpo-31627 that a host without a hostname is misconfigured. Since this change is only in a test, would it be better to mock socket.gethostname() so that it doesn't return an empty hostname?

@bitdancer
Copy link
Member

bitdancer commented Sep 29, 2017

Since the change doesn't weaken the test, I think we should not bother with a mock. This way if some weird hostname causes a real bug, we might get a report. With a mock, we'd miss that.

@serhiy-storchaka serhiy-storchaka merged commit f4ea642 into python:master Sep 30, 2017
@miss-islington
Copy link
Contributor

miss-islington commented Sep 30, 2017

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@serhiy-storchaka serhiy-storchaka deleted the test_mailbox-empty-hostname branch September 30, 2017 14:11
@miss-islington
Copy link
Contributor

miss-islington commented Sep 30, 2017

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 30, 2017

Sorry @serhiy-storchaka, I had trouble checking out the 2.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f4ea642cb60556231e714089a79d3c59c202661e 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2017
@serhiy-storchaka @miss-islington
[3.6] bpo-31627: Make test_mailbox be lenient to empty hostname. (pyt…
2e48364 
…honGH-3821)

(cherry picked from commit f4ea642)
@bedevere-bot
Copy link

bedevere-bot commented Sep 30, 2017

GH-3837 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 30, 2017
@serhiy-storchaka
[2.7] bpo-31627: Make test_mailbox be lenient to empty hostname. (pyt…
cb32a8a 
…honGH-3821)

(cherry picked from commit f4ea642)
@bedevere-bot
Copy link

bedevere-bot commented Sep 30, 2017

GH-3838 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka pushed a commit that referenced this pull request Sep 30, 2017
@miss-islington @serhiy-storchaka
[3.6] bpo-31627: Make test_mailbox be lenient to empty hostname. (GH-…
d9c21a4 
…3821) (#3837)

(cherry picked from commit f4ea642)
serhiy-storchaka added a commit that referenced this pull request Sep 30, 2017
@serhiy-storchaka
[2.7] bpo-31627: Make test_mailbox be lenient to empty hostname. (GH-…
1163fb9 
…3821) (#3838)

(cherry picked from commit f4ea642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw left review comments

@bitdancer bitdancer bitdancer approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @bitdancer @miss-islington @bedevere-bot @warsaw @Mariatta