[2.7] bpo-31675: Fix memory leaks in Tkinter's methods splitlist() and split() (GH-3866) #3876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d split() (pythonGH-3866) when pass a string larger than 2 GiB. Decrease memory requirements for Tcl's bigmem tests.. (cherry picked from commit 27c623c)
vstinner
reviewed
Oct 3, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
While the PR seems good to me, I'm not sure that a NEWS entry is really needed. _tkinter.c doesn't have "#define PY_SSIZE_T_CLEAN" in Python 2.7, and so already rejected strings longer than INT_MAX in PyArg_ParseTuple(), no?
Member
Author
|
PY_SSIZE_T_CLEAN affects the type of the size variable. But "et" doesn't return a size. |
Member
Oh, I see. Thank you for checking. Your PR now LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when pass a string larger than 2 GiB.
(cherry picked from commit 27c623c)
https://bugs.python.org/issue31675