[3.6] bpo-31457: Don't omit inner process() calls with nested LogAdapters
#4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs (pythonGH-4044) This used to be the case on Python 2. Commit 212b590 changed the implementation for Python 3, making the `log()` method of LogAdapter call `logger._log()` directly. This makes nested log adapters not execute their ``process()`` method. This patch fixes the issue. Also, now proxying `name`, too, to make `repr()` work with nested log adapters. New tests added. (cherry picked from commit ce9e625)
Mariatta
changed the title
process() calls with nested LogAdapters
Mariatta
approved these changes
Oct 19, 2017
Contributor
Author
|
Thanks, @Mariatta! |
Contributor
|
Yup, thanks Mariatta! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be the case on Python 2. Commit
212b590 changed the implementation for Python
3, making the
log()method of LogAdapter calllogger._log()directly. Thismakes nested log adapters not execute their
process()method. This patchfixes the issue.
Also, now proxying
name, too, to makerepr()work with nested log adapters.New tests added.
(cherry picked from commit ce9e625)
https://bugs.python.org/issue31457