bpo-31174: Fix test_tools.test_unparse #4102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_unparse.DirectoryTestCase now stores the names sample to always test the same files. It prevents false alarms when hunting reference leaks.
|
|
||
| def test_files(self): | ||
| # get names of files to test | ||
| def get_names(self): |
Member
There was a problem hiding this comment.
Wouldn't be better to make it a static method?
Member
Author
There was a problem hiding this comment.
I prefer to use a regular method, even if technically a staticmethod would work, since the method depends on the class.
Member
There was a problem hiding this comment.
If the method depends on the class, make it a class method.
But in that case you should use cls.NAMES instead of DirectoryTestCase.NAMES.
Contributor
|
Thanks @Haypo for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 24, 2017
test_unparse.DirectoryTestCase now stores the names sample to always test the same files. It prevents false alarms when hunting reference leaks. (cherry picked from commit 8e482be)
|
GH-4104 is a backport of this pull request to the 3.6 branch. |
vstinner
pushed a commit
that referenced
this pull request
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_unparse.DirectoryTestCase now stores the names sample to always
test the same files. It prevents false alarms when hunting reference
leaks.
https://bugs.python.org/issue31174