[2.7] bpo-21149: Workaround a GC finalization bug in logging. #4368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
changed the title
The logging RLock instances may exist but the threading.RLock class itself has already been emptied causing a Exception TypeError: "'NoneType' object is not callable" in <function _removeHandlerRef ..." to be printed to stderr on process termination. This catches that exception and ignores it because there is absolutely nothing we can or should do about it from the context of a weakref handler called from the gc context.
gpshead
force-pushed
the
issue21149_removeHandlerRef_workaround
branch
from
4fb5489 to
bb43dbc
Compare
Member
Author
|
This is non-deterministic as it depends on the order the garbage collection and finalization happen in, creating a unittest for this doesn't make much sense. |
| finally: | ||
| release() | ||
| except TypeError: | ||
| # https://bugs.python.org/issue21149 - If the RLock object behind |
Member
There was a problem hiding this comment.
Would sys.is_finalizing() help here?
Member
There was a problem hiding this comment.
Ah, forgot, this is 2.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging RLock instances may exist but the threading.RLock class
itself has already been emptied causing a
Exception TypeError: "'NoneType' object is not callable" in <function _removeHandlerRef ..."
to be printed to stderr on process termination.
This catches that exception and ignores it because there is absolutely
nothing we can or should do about it from the context of a weakref
handler called from the gc context.
https://bugs.python.org/issue21149