Skip to content

bpo-32047: -X dev enables asyncio debug mode #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 2 commits into from
Nov 20, 2017
Merged

bpo-32047: -X dev enables asyncio debug mode #4418

vstinner merged 2 commits into from
Nov 20, 2017

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Nov 16, 2017 •
edited by bedevere-bot
Loading

The new -X dev command line option now also enables asyncio debug
mode.

https://bugs.python.org/issue32047

@vstinner
bpo-32047: -X dev enables asyncio debug mode
1ba9493 
The new -X dev command line option now also enables asyncio debug
mode.
@vstinner vstinner requested a review from 1st1 as a code owner November 16, 2017 11:51
@vstinner vstinner requested a review from asvetlov November 16, 2017 11:51
1st1
1st1 reviewed Nov 16, 2017
View reviewed changes
Lib/asyncio/coroutines.py Outdated
_DEBUG = (not sys.flags.ignore_environment and
bool(os.environ.get('PYTHONASYNCIODEBUG')))

def _debug_mode():
Copy link
Member

@1st1 1st1 Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename this function to _is_debug_mode

Copy link
Member Author

@vstinner vstinner Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

1st1
1st1 requested changes Nov 16, 2017
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR looks good. Please hold off merging it though, until we have a consensus on the mailing list (or till Monday, whatever comes first :))

@bedevere-bot
Copy link

bedevere-bot commented Nov 16, 2017

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner vstinner merged commit 44862df into python:master Nov 20, 2017
@vstinner vstinner deleted the xdev_asyncio branch November 20, 2017 15:14
@vstinner
Copy link
Member Author

vstinner commented Nov 20, 2017

Overall the PR looks good. Please hold off merging it though, until we have a consensus on the mailing list (or till Monday, whatever comes first :))

We are Monday, I merged the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 requested changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @bedevere-bot @1st1 @the-knights-who-say-ni