bpo-31672 - Add one last minor clarification for idpattern #4483
Conversation
| # backward compatibility. So we use local -i flag and [a-zA-Z] pattern. | ||
| # See https://bugs.python.org/issue31672 | ||
| idpattern = r'(?-i:[_a-zA-Z][_a-zA-Z0-9]*)' | ||
| idpattern = r'(?a:[_a-zA-Z][_a-zA-Z0-9]*)' |
There was a problem hiding this comment.
How about changing a-zA-Z to a-z?
There was a problem hiding this comment.
And update the comment above.
There was a problem hiding this comment.
Actually, I don't think we can remove A-Z from the pattern because that could be seen as a backward compatibility break. E.g. what if there's code out there that sets flags=0? Then the regexp wouldn't be case-insensitive and the removal of A-Z would break that code.
I think it is safe to swap a for -i though, so I'll do that. I'll also update the comment and, as I just also noticed, the documentation.
There was a problem hiding this comment.
This will just return the situation before the initial fix of this issue, but with correctly fixed bug. Initially the pattern was r'[_a-z][_a-z0-9]*', later it was changed to r'(?-i:[_a-zA-Z][_a-zA-Z0-9]*)', and now we can use r'(?a:[_a-z][_a-z0-9]*)' which is a fixed (ASCII-only) version of r'[_a-z][_a-z0-9]*'.
5 participants
This should be the last minor diff for bpo-31672
https://bugs.python.org/issue31672