bpo-32030: Add _PyMainInterpreterConfig.pythonhome #4513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Py_Main() now reads the PYTHONHOME environment variable * Add _Py_GetPythonHomeWithConfig() private function
* init_filters() doesn't get the current core configuration from the current interpreter or Python thread anymore. Pass explicitly the configuration to _PyWarnings_InitWithConfig(). * _Py_InitializeCore() now fails on _PyWarnings_InitWithConfig() failure. * Pass configuration as constant
ncoghlan
changed the title
ncoghlan
approved these changes
Nov 23, 2017
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
I tweaked the PR title to use the right struct name, so this looks good to me!
|
|
||
| wchar_t * | ||
| Py_GetPythonHome(void) | ||
| _Py_GetPythonHomeWithConfig(const _PyMainInterpreterConfig *config) |
Contributor
There was a problem hiding this comment.
I'm not sure I actually like this API design, but since it's an internal API, I don't have any obviously better ideas, and we expect further refactoring of this code in the future, I'm also not going to quibble over it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32030