[3.8] bpo-10544: Disallow "yield" in comprehensions and generator expressions. #4564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
changed the title
serhiy-storchaka
force-pushed
the
disallow-yield-in-comprehencions
branch
from
f4f684d to
6d5e555
Compare
ncoghlan
requested changes
Dec 1, 2017
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
Just adding a blocking review to ensure we don't merge this until after the 3.7 maintenance branch has been created.
|
When you're done making the requested changes, leave the comment: |
Member
Author
|
Could you please look on this again Nick? |
ncoghlan
approved these changes
Feb 4, 2018
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
LGTM, and the main branch is now open for 3.8 commits.
| @@ -0,0 +1,2 @@ | |||
| Yield expressions now are disallowed in comprehensions and generator | |||
Contributor
There was a problem hiding this comment.
Minor wording tweak: now are -> are now
Member
Author
|
Maybe you can suggest better wording for What's New? |
Contributor
|
The What's New wording seemed fine to me. |
Member
Author
|
Thank you @ncoghlan for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue10544