bpo-31705: Skip test_socket.test_sha256() on ppc64 #4643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
My first patch only skipped the test_sha256() on kernel < 4.11 on ppc64. My second patch skipped test_sha256() on kernel < 4.5 for any architecture. My third patch added a NEWS enty. Ok, now we should be good :-) |
tiran
approved these changes
Nov 30, 2017
Member
tiran
left a comment
tiran
left a comment
There was a problem hiding this comment.
LGTM
The test isn't that important. I'm totally fine with skipping it on older Linux Kernels. It's not our business to verify the Kernel API. :)
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-4645 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 30, 2017
bpo-31705. (cherry picked from commit 86afc1f)
vstinner
pushed a commit
that referenced
this pull request
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip test_socket.test_sha256() on ppc64 for kernel version older than
4.11.
https://bugs.python.org/issue31705