[3.6] bpo-32137: The repr of deeply nested dict now raises a RecursionError (GH-4570) #4689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pythonGH-4570) instead of crashing due to a stack overflow. This perhaps will fix similar problems in other extension types. (cherry picked from commit 1fb72d2)
Contributor
Author
|
@serhiy-storchaka: Backport status check is done, and it's a success ✅ . |
vstinner
approved these changes
Dec 4, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. IMHO it's ok to do this change in 3.6.
vstinner
approved these changes
Dec 12, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
IMHO this change is ok for Python 3.6.
Member
|
Thank you @vstinner, I have some doubts. I want to know the opinion of @rhettinger before merging one of this PRs. |
Contributor
Author
|
Thanks @miss-islington for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7. |
Contributor
Author
|
Thanks, @serhiy-storchaka! |
Contributor
Author
|
Sorry, @miss-islington and @serhiy-storchaka, I could not cleanly backport this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of crashing due to a stack overflow.
This perhaps will fix similar problems in other extension types.
(cherry picked from commit 1fb72d2)
https://bugs.python.org/issue32137