bpo-32207: Improve tk event exception tracebacks in IDLE. #4703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tk event handling is driven by IDLE's run loop, a confusing and distracting queue.EMPTY traceback context is no longer added to tk event exception tracebacks. The traceback is now the same as when event handling is driven by user code. Patch based on a suggestion by Serhiy Storchaka.
| Improve tk event exception tracebacks in IDLE. | ||
|
|
||
| When tk event handling is driven by IDLE's run loop, a confusing | ||
|
|
|
|
||
| to tk event exception tracebacks. The traceback is now the same | ||
|
|
||
| as when event handling is driven by user code. Patch based on a suggestion |
Member
There was a problem hiding this comment.
Redundant space duplication before "a".
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Have you tested this code? I didn't.
Remove blank lines added by something other than me.
serhiy-storchaka
approved these changes
Dec 4, 2017
Member
Author
|
The blank lines were not in the text I wrote in Notepad, opened by blurb. I removed them and then updated blurb in case it has changed its processing of the file after closing. I manually tested the patch running the example from an IDLE editor, without 'root.mainloop', so that the callbacks are handled by handle_tk_events. I then submitted multiple statements, including further root.after calls, at >>> prompts. |
Contributor
|
Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 4, 2017
) When tk event handling is driven by IDLE's run loop, a confusing and distracting queue.EMPTY traceback context is no longer added to tk event exception tracebacks. The traceback is now the same as when event handling is driven by user code. Patch based on a suggestion by Serhiy Storchaka. (cherry picked from commit 1e2fcac)
|
GH-4705 is a backport of this pull request to the 3.6 branch. |
terryjreedy
pushed a commit
that referenced
this pull request
Dec 4, 2017
…4705) When tk event handling is driven by IDLE's run loop, a confusing and distracting queue.EMPTY traceback context is no longer added to tk event exception tracebacks. The traceback is now the same as when event handling is driven by user code. Patch based on a suggestion by Serhiy Storchaka. (cherry picked from commit 1e2fcac)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tk event handling is driven by IDLE's run loop, a confusing
and distracting queue.EMPTY traceback context is no longer added
to tk event exception tracebacks. The traceback is now the same
as when event handling is driven by user code. Patch based on
a suggestion by Serhiy Storchaka.
https://bugs.python.org/issue32207