Skip to content

Conversation

@izbyshev
Copy link
Contributor

@izbyshev izbyshev commented Dec 9, 2017

Set SRCDIR as the current directory for git and hg.

https://bugs.python.org/issue32256

Set SRCDIR as the current directory for git and hg.
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@@ -0,0 +1 @@
Make patchcheck.py work for out-of-tree builds.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No NEWS entry needed for PRs like this.

@berkerpeksag berkerpeksag requested a review from ncoghlan August 24, 2018 18:09
@vstinner
Copy link
Member

I tested manually and I confirm that it works as expected.

@vstinner vstinner merged commit aa95bfb into python:master Oct 20, 2018
@miss-islington
Copy link
Contributor

Thanks @izbyshev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-9992 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2018
)

Set SRCDIR as the current directory for git.
(cherry picked from commit aa95bfb)

Co-authored-by: Alexey Izbyshev <[email protected]>
@bedevere-bot
Copy link

GH-9993 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2018
)

Set SRCDIR as the current directory for git.
(cherry picked from commit aa95bfb)

Co-authored-by: Alexey Izbyshev <[email protected]>
miss-islington added a commit that referenced this pull request Oct 20, 2018
Set SRCDIR as the current directory for git.
(cherry picked from commit aa95bfb)

Co-authored-by: Alexey Izbyshev <[email protected]>
miss-islington added a commit that referenced this pull request Oct 20, 2018
Set SRCDIR as the current directory for git.
(cherry picked from commit aa95bfb)

Co-authored-by: Alexey Izbyshev <[email protected]>
@izbyshev izbyshev deleted the bpo-32256 branch October 20, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants