Skip to content

[3.6] bpo-29615: SimpleXMLRPCDispatcher no longer chains KeyError (or any other exception) to exception(s) raised in the dispatched methods. #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Mar 5, 2017
Merged

[3.6] bpo-29615: SimpleXMLRPCDispatcher no longer chains KeyError (or any other exception) to exception(s) raised in the dispatched methods. #478

serhiy-storchaka merged 1 commit into from
Mar 5, 2017

Conversation

@petr-motejlek
Copy link
Contributor

@petr-motejlek petr-motejlek commented Mar 5, 2017

No description provided.

@serhiy-storchaka serhiy-storchaka self-assigned this Mar 5, 2017
@petr-motejlek
Copy link
Contributor Author

petr-motejlek commented Mar 5, 2017

@serhiy-storchaka , I tried to add the proper cherry pick label myself, but could not find a place to do that. What am I missing, please? :)

@Mariatta
Copy link
Member

Mariatta commented Mar 5, 2017

@petr-motejlek only those with write permission can apply labels :)
Also this PR doesn't appear to be done via git cherry-pick command?

@petr-motejlek
Copy link
Contributor Author

petr-motejlek commented Mar 5, 2017

@Mariatta , cherry pick seemed to pick up some unrelated changes (from 3.7) and to get rid of them I had to manually edit some of the commits. So, I cleaned up the diff and squashed all changes into one simple commit

@petr-motejlek petr-motejlek mentioned this pull request Mar 5, 2017
Merged
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Mar 5, 2017

@Mariatta, I'm not well experienced with Git and GitHub. Is there something wrong with this PR?

@Mariatta
Copy link
Member

Mariatta commented Mar 5, 2017

@serhiy-storchaka I think it's fine :) You can merge it. Thanks.

@petr-motejlek
Copy link
Contributor Author

petr-motejlek commented Mar 5, 2017

Thanks, guys :)

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Mar 5, 2017

Thanks @Mariatta.

@serhiy-storchaka serhiy-storchaka merged commit 3405792 into python:3.6 Mar 5, 2017
@petr-motejlek petr-motejlek deleted the bpo-29615-3.6 branch March 5, 2017 16:21
@serhiy-storchaka serhiy-storchaka removed their assignment Dec 6, 2018
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@ambv
Upgrade production to Python 3.9.6 (#478)
b7c066b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petr-motejlek @Mariatta @serhiy-storchaka @the-knights-who-say-ni