bpo-29469: Optimize literal lists and sets iterating on the AST level. #4866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
reviewed
Dec 14, 2017
| return make_const(node, newval, arena); | ||
| } | ||
|
|
||
| static int |
Member
There was a problem hiding this comment.
It would be nice to add comments and/or a "docstring" to explain what this is doing.
pitrou
reviewed
Dec 14, 2017
| } | ||
|
|
||
| static int | ||
| fold_compare(expr_ty node, PyArena *arena) |
Member
Author
There was a problem hiding this comment.
This already is documented inside the function. In future the optimization for literal operands (like 1 < 2) can be added here, but currently it optimizes only the particular case of 'in' and 'not in' operators.
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue29469