bpo-32323: urllib.parse.urlsplit() must not lowercase() IPv6 scope value #4867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
asvetlov
reviewed
Dec 15, 2017
Lib/urllib/parse.py
Outdated
Contributor
There was a problem hiding this comment.
Drop parentheses at left of =, the module doesn't use this style.
Contributor
There was a problem hiding this comment.
I recommend considering hostname.partition('%') -- it makes code cleaner.
Lib/urllib/parse.py
Outdated
asvetlov
approved these changes
Dec 21, 2017
Contributor
|
Thanks @socketpair for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 21, 2017
…lue (pythonGH-4867) (cherry picked from commit fbd6051)
|
GH-4959 is a backport of this pull request to the 3.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32323