bpo-32365: Fix a reference leak when compile __debug__. #4916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was introduced in bpo-27169.
vstinner
approved these changes
Dec 18, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I didn't check if the change is correct, but I confirm that it fix the reference leak using "./python -m test -R 3:3 test_ast test_builtin test_compile".
Note: I had to disable PtyTests in test_builtin, but it's unrelated to this PR.
methane
approved these changes
Dec 18, 2017
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 18, 2017
It was introduced in bpo-27169. (cherry picked from commit bd6ec4d)
|
GH-4918 is a backport of this pull request to the 3.6 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was introduced in bpo-27169.
https://bugs.python.org/issue32365