Skip to content

bpo-32360: Remove OrderedDict reference as dicts are ordered now #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
methane merged 2 commits into from
Jan 24, 2018
Merged

bpo-32360: Remove OrderedDict reference as dicts are ordered now #4994

methane merged 2 commits into from
Jan 24, 2018

Conversation

@srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Dec 23, 2017 •
edited by bedevere-bot
Loading

merwok
merwok reviewed Dec 23, 2017
View reviewed changes
@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Jan 2, 2018 •
edited
Loading

@asvetlov Just a question. Tagging someone who can review and merge is fine here? If so, could you please look into this PR? 😄

merwok
merwok reviewed Jan 2, 2018
View reviewed changes
Misc/NEWS.d/next/Documentation/2017-12-24-17-29-37.bpo-32360.eZe-ID.rst Outdated
Copy link
Member

@merwok merwok Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find «reference» a bit vague, what do you think about using «import» instead?

Copy link
Member

@methane methane Jan 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think NEWS entry is required for this.
You can use "skip news" label instead

merwok
merwok reviewed Jan 2, 2018
View reviewed changes
Lib/unittest/util.py Outdated
Copy link
Member

@merwok merwok Jan 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The collections module ends up loaded anyway, so removing OrderedDict doesn’t really change anything for this module. @rhettinger would you mind giving your opinion for this PR?

methane
methane requested changes Jan 18, 2018
View reviewed changes
Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you use collections.Counter instead?

Misc/NEWS.d/next/Documentation/2017-12-24-17-29-37.bpo-32360.eZe-ID.rst Outdated
Copy link
Member

@methane methane Jan 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think NEWS entry is required for this.
You can use "skip news" label instead

@bedevere-bot
Copy link

bedevere-bot commented Jan 18, 2018

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Jan 23, 2018

@methane Done. Thanks for the review.

@srinivasreddy
Copy link
Contributor Author

srinivasreddy commented Jan 24, 2018

@methane Please add skip-news label too.!!

@methane methane merged commit 018e1b7 into python:master Jan 24, 2018
@srinivasreddy srinivasreddy deleted the 32360 branch January 24, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@methane methane methane approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@srinivasreddy @bedevere-bot @methane @merwok @the-knights-who-say-ni