Skip to content

[3.6] bpo-32282: Remove unnecessary check for VersionHelpers.h in socketmodule.c on Windows #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
berkerpeksag merged 1 commit into from
May 18, 2018
Merged

[3.6] bpo-32282: Remove unnecessary check for VersionHelpers.h in socketmodule.c on Windows #5120

berkerpeksag merged 1 commit into from
May 18, 2018

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 7, 2018 •
edited by bedevere-bot
Loading

(cherry picked from commit af11a15)

https://bugs.python.org/issue32282

@maxbelanger @miss-islington
bpo-32282: Remove unnecessary check for VersionHelpers.h in `socket…
963008f 
…module.c` on Windows

(cherry picked from commit af11a15)
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Feb 26, 2018
@Mariatta
Copy link
Member

Mariatta commented Mar 10, 2018

@zooba is this ok to be merged?

@berkerpeksag berkerpeksag merged commit 09eb6fe into python:3.6 May 18, 2018
@miss-islington
Copy link
Contributor Author

miss-islington commented May 18, 2018

Thanks, @berkerpeksag!

@miss-islington miss-islington deleted the backport-af11a15-3.6 branch May 18, 2018 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@zooba zooba

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@miss-islington @Mariatta @berkerpeksag @zooba @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot @maxbelanger