Skip to content

Implement the get_resource_reader() API for file system imports #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
warsaw merged 10 commits into from
Jan 15, 2018
Merged

Implement the get_resource_reader() API for file system imports #5168

warsaw merged 10 commits into from
Jan 15, 2018

Conversation

@warsaw
Copy link
Member

@warsaw warsaw commented Jan 12, 2018

No description provided.

@warsaw
Copy link
Member Author

warsaw commented Jan 12, 2018

@brettcannon I've moved the zipimport work to a separate branch, still in progress.

@brettcannon brettcannon self-requested a review January 12, 2018 20:33
brettcannon
brettcannon requested changes Jan 12, 2018
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great overall, but we do need docs for this.

@bedevere-bot
Copy link

bedevere-bot commented Jan 12, 2018

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@warsaw
Copy link
Member Author

warsaw commented Jan 13, 2018

@brettcannon Didn't you just land the docs for this in bca4218 ?

@warsaw
Copy link
Member Author

warsaw commented Jan 13, 2018

I have made the requested changes; please review again

@python python deleted a comment from bedevere-bot Jan 13, 2018
@warsaw
Copy link
Member Author

warsaw commented Jan 15, 2018

@brettcannon Ping. I'm rebasing my zipimporter branch on top of this one, so I'd like to land it soon. See my previous comment about the docs.

@brettcannon
Copy link
Member

brettcannon commented Jan 15, 2018

I landed the docs for the ABC, but I didn't document anything relating to the changes in this PR. I've gone ahead and approved this so you can get your zipimporter changes in as we can do doc changes in after b1 if necessary.

@warsaw warsaw merged commit 5ec0fee into python:master Jan 15, 2018
@warsaw warsaw deleted the resource-reader branch January 16, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@warsaw @bedevere-bot @brettcannon @the-knights-who-say-ni