Skip to content

bpo-32576: use queue.SimpleQueue in critical places #5216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pitrou merged 1 commit into from
Jan 18, 2018
Merged

bpo-32576: use queue.SimpleQueue in critical places #5216

pitrou merged 1 commit into from
Jan 18, 2018

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Jan 17, 2018 •
edited by bedevere-bot
Loading

Where a queue may be invoked from a weakref callback, we need to use the reentrant SimpleQueue.

https://bugs.python.org/issue32576

@pitrou
bpo-32576: use queue.SimpleQueue in critical places
52be423 
Where a queue may be invoked from a weakref callback, we need
to use the reentrant SimpleQueue.
@pitrou pitrou requested a review from gpshead January 17, 2018 12:13
@gpshead
Copy link
Member

gpshead commented Jan 17, 2018

I don't know the multiprocessing internals well but I believe this makes sense after reading through the code and looking at where things are passed and used. Can you verify that this fixes the executor-hang.py reproducer in https://bugs.python.org/issue21009?

@pitrou
Copy link
Member Author

pitrou commented Jan 18, 2018

Can you verify that this fixes the executor-hang.py reproducer in https://bugs.python.org/issue21009?

Unfortunately the reproducer works by monkey-patching queue.Queue, which obviously won't trigger the issue with this PR.

@pitrou pitrou merged commit ab74504 into python:master Jan 18, 2018
@pitrou pitrou deleted the use_simplequeue branch January 18, 2018 09:38
tomMoral added a commit to tomMoral/cpython that referenced this pull request Apr 6, 2018
@tomMoral
FIX different fix for python#5216
02503a7
@jorenvanlindert jorenvanlindert mentioned this pull request Jan 19, 2019
Closed
@YouJiacheng YouJiacheng mentioned this pull request Jul 13, 2022
Merged
@gpshead gpshead mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou @gpshead @the-knights-who-say-ni @bedevere-bot