bpo-31848: Fix broken error handling in Aifc_read.initfp() when the SSND chunk is not found #5240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SND chunk is not found Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError.
serhiy-storchaka
added
type-bug
Member
|
Please add your name in Misc/ACKS and add "Patch by your name." in the news file. |
serhiy-storchaka
approved these changes
Feb 20, 2018
|
@serhiy-storchaka: Please replace |
Contributor
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 20, 2018
…SND chunk is not found (pythonGH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
|
GH-5780 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 20, 2018
…SND chunk is not found (pythonGH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
|
GH-5781 is a backport of this pull request to the 2.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 20, 2018
…SND chunk is not found (pythonGH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
|
GH-5782 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 20, 2018
…SND chunk is not found (GH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Feb 20, 2018
…SND chunk is not found (GH-5240) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 21, 2018
… the SSND chunk is not found (GH-5240) (GH-5781) Initialize self._ssnd_chunk so that aifc.Error is raised as intended, not AttributeError. (cherry picked from commit 80d20b9) Co-authored-by: Zackery Spytz <[email protected]>
Contributor
Author
|
Thank you @serhiy-storchaka. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize self._ssnd_chunk so that aifc.Error is raised as intended,
not AttributeError.
This mirrors what is done in Wave_read.initfp() for self._data_chunk.
https://bugs.python.org/issue31848