Skip to content

bpo-29742: asyncio get_extra_info() throws exception #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1st1 merged 1 commit into from
Mar 12, 2017
Merged

bpo-29742: asyncio get_extra_info() throws exception #525

1st1 merged 1 commit into from
Mar 12, 2017

Conversation

@fafhrd91
Copy link
Contributor

@fafhrd91 fafhrd91 commented Mar 6, 2017

@mention-bot
Copy link

mention-bot commented Mar 6, 2017

@fafhrd91, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo, @1st1, @serhiy-storchaka and @vadmium to be potential reviewers.

@fafhrd91 fafhrd91 mentioned this pull request Mar 6, 2017
Open
@1st1 1st1 self-requested a review March 6, 2017 21:27
1st1
1st1 approved these changes Mar 6, 2017
View reviewed changes
Copy link
Member

@1st1 1st1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@1st1
Copy link
Member

1st1 commented Mar 6, 2017

Could you please also add a NEWS entry?

@fafhrd91
Copy link
Contributor Author

fafhrd91 commented Mar 6, 2017

@1st1 do I need to create correspondent bpo issue?

@1st1
Copy link
Member

1st1 commented Mar 6, 2017 •
edited
Loading

@1st1 do I need to create correspondent bpo issue?

Yes, please!

@fafhrd91
Copy link
Contributor Author

fafhrd91 commented Mar 6, 2017

added news entry

1st1
1st1 reviewed Mar 6, 2017
View reviewed changes
Lib/asyncio/sslproto.py Outdated
Copy link
Member

@1st1 1st1 Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return default, not None. Please also add a test for this.

Copy link
Contributor Author

@fafhrd91 fafhrd91 Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right. fixed

@1st1 1st1 changed the title asyncio get_extra_info() throws exception bpo-29742: asyncio get_extra_info() throws exception Mar 6, 2017
@1st1 1st1 merged commit 2b27e2e into python:master Mar 12, 2017
1st1 pushed a commit to 1st1/cpython that referenced this pull request Mar 12, 2017
@fafhrd91 @1st1
bpo-29742: asyncio get_extra_info() throws exception (python#525)
d4f44d0
1st1 pushed a commit to 1st1/cpython that referenced this pull request Mar 12, 2017
@fafhrd91 @1st1
bpo-29742: asyncio get_extra_info() throws exception (python#525)
6f1987b
1st1 added a commit that referenced this pull request Mar 12, 2017
@1st1
bpo-29742: asyncio get_extra_info() throws exception (#525) (#646)
db522dc
1st1 added a commit that referenced this pull request Mar 12, 2017
@1st1
bpo-29742: asyncio get_extra_info() throws exception (#525) (#645)
99f8d33
@azeroth12 azeroth12 mentioned this pull request Aug 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fafhrd91 @mention-bot @1st1 @Mariatta @the-knights-who-say-ni