Skip to content

bpo-32670: Enforce PEP 479. #5327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1st1 merged 2 commits into from
Jan 26, 2018
Merged

bpo-32670: Enforce PEP 479. #5327

1st1 merged 2 commits into from
Jan 26, 2018

Conversation

@1st1
Copy link
Member

@1st1 1st1 commented Jan 25, 2018 •
edited by bedevere-bot
Loading

@1st1 1st1 requested review from ncoghlan and vstinner January 25, 2018 22:04
@1st1 1st1 requested a review from methane January 26, 2018 05:20
methane
methane approved these changes Jan 26, 2018
View reviewed changes
Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@csabella
Copy link
Contributor

csabella commented Jan 26, 2018

Does this need to be mentioned in the docs?

@1st1
Copy link
Member Author

1st1 commented Jan 26, 2018

Does this need to be mentioned in the docs?

Yep, fixed.

@1st1 1st1 merged commit 43c47fe into python:master Jan 26, 2018
@1st1 1st1 deleted the pep479 branch January 26, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@1st1 @csabella @methane @the-knights-who-say-ni @bedevere-bot