bpo-32674: minor documentation fix for '__import__' #5339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csabella
reviewed
Jan 27, 2018
Python/bltinmodule.c
Outdated
| fromlist is not empty. Level is used to determine whether to perform \n\ | ||
| absolute or relative imports. 0 is absolute while a positive number\n\ | ||
| fromlist is not empty. The level argument is used to determine whether to\n\ | ||
| perform absolute or relative imports, 0 is absolute while a positive number\n\ |
Contributor
There was a problem hiding this comment.
With this change, I believe your new comma should be a semi-colon. imports; 0 is absolute
Contributor
Author
There was a problem hiding this comment.
Isn't colon better than semi colon here? BTW, should I add a new commit on top of this or amend this commit?
Member
There was a problem hiding this comment.
We prefer you don't amend commits, so add a new one. Thanks.
Member
|
Hi @Mariatta |
Mariatta
approved these changes
Feb 2, 2018
Contributor
|
GH-5488 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2018
Clarify that the level argument is used to determine whether to perform absolute or relative imports: 0 is absolute, while a positive number is the number of parent directories to search relative to the current module. (cherry picked from commit 461d225) Co-authored-by: oldk <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2018
Clarify that the level argument is used to determine whether to perform absolute or relative imports: 0 is absolute, while a positive number is the number of parent directories to search relative to the current module. (cherry picked from commit 461d225) Co-authored-by: oldk <[email protected]>
|
GH-5489 is a backport of this pull request to the 3.6 branch. |
Contributor
|
Sorry, @oldk1331 and @Mariatta, I could not cleanly backport this to |
Mariatta
pushed a commit
that referenced
this pull request
Feb 2, 2018
Clarify that the level argument is used to determine whether to perform absolute or relative imports: 0 is absolute, while a positive number is the number of parent directories to search relative to the current module. (cherry picked from commit 461d225) Co-authored-by: oldk <[email protected]>
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
Feb 2, 2018
Clarify that the level argument is used to determine whether to perform absolute or relative imports: 0 is absolute, while a positive number is the number of parent directories to search relative to the current module.. (cherry picked from commit 461d225) Co-authored-by: oldk <[email protected]>
|
GH-5494 is a backport of this pull request to the 2.7 branch. |
Mariatta
pushed a commit
that referenced
this pull request
Feb 2, 2018
Clarify that the level argument is used to determine whether to perform absolute or relative imports: 0 is absolute, while a positive number is the number of parent directories to search relative to the current module. (cherry picked from commit 461d225) Co-authored-by: oldk <[email protected]>
Mariatta
added a commit
that referenced
this pull request
Feb 2, 2018
Clarify that the level argument is used to determine whether to perform absolute or relative imports: 0 is absolute, while a positive number is the number of parent directories to search relative to the current module.. (cherry picked from commit 461d225) Co-authored-by: oldk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32674
This is a minor documentation fix for builtin function
__import__.https://bugs.python.org/issue32674