bpo-32685: Improve suggestion for print statement #5375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoghlan
approved these changes
Jan 28, 2018
Contributor
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
I have some suggestions for minor cosmetic improvements, but I'm just going to make those directly in order to get the CI running again before I merge it.
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 28, 2018
Better account for single-line compound statements and semi-colon separated statements when suggesting Py3 replacements for Py2 print statements. Initial patch by Nitish Chandra. (cherry picked from commit 43c0f1a)
|
GH-5380 is a backport of this pull request to the 3.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Nick Coghlan's suggestion, used
startattribute passed to_set_legacy_print_statement_msgand also made changes to use only the text before ';' as the suggestion.https://bugs.python.org/issue32685