bpo-28414: ssl module idna test #5395
Conversation
njsmith
left a comment
njsmith
left a comment
There was a problem hiding this comment.
Looks good except for one minor comment.
I'm kind of confused about what your overall plan for this is right now – are you still planning to make sslsock.server_hostname be an A-label? Are you still planning to fix the SNI callback as discussed previously?
Should there also be tests for SSLObject's handling of server_hostname?
Lib/test/test_ssl.py
Outdated
There was a problem hiding this comment.
This comment does not appear to match what this is testing right now.
There was a problem hiding this comment.
Oh, thanks. I fixed the comment
|
I clarified the commit message. I'll address IDNA 2008 after beta 1. Ned granted an exception. This PR just proofs that most IDNA cases are working. Only IDNA 2008 deviations like German' ß are still not working yet. I'll also add SSLObject tests when I fix IDNA 2008. Right now SSLObject behaves slightly differently (of course) and I'm having a hard time to write a test for it. |
Add test cases for IDNA 2003 and 2008 host names. IDNA 2003 internationalized host names are working since bpo-31399 has landed. IDNA 2008 deviations are still broken and will be fixed in another patch. Signed-off-by: Christian Heimes <[email protected]>
|
@tiran: Please replace |
4 participants
Add test cases for IDNA 2003 and 2008 host names. IDNA 2003
internationalized host names are working since bpo-31399 has landed. IDNA
2008 deviations are still broken and will be fixed in another patch.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue28414