Skip to content

bpo-32720: Fixed incorrect definition in format mini-language doc #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mariatta merged 1 commit into from
Feb 4, 2018
Merged

bpo-32720: Fixed incorrect definition in format mini-language doc #5482

Mariatta merged 1 commit into from
Feb 4, 2018

Conversation

@nathankerr96
Copy link
Contributor

@nathankerr96 nathankerr96 commented Feb 2, 2018 •
edited by bedevere-bot
Loading

  • Changed definition of width and precision from "integer" to "digit+" to reflect actual behavior

https://bugs.python.org/issue32720

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Feb 2, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@csabella
Copy link
Contributor

csabella commented Feb 2, 2018

LGTM.

@nathankerr96
Copy link
Contributor Author

nathankerr96 commented Feb 4, 2018

CLA has been signed and verified, please re-run the check when possible.

Since this is a very small documentation change, I'm not sure if it needs a news entry. Please add the skip news tag or let me know if I should in fact add a news entry.

@Mariatta Mariatta added the docs Documentation in the Doc dir label Feb 4, 2018
@Mariatta Mariatta merged commit 8b5fa28 into python:master Feb 4, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Feb 4, 2018

Thanks @nathankerr96 for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Mariatta commented Feb 4, 2018

Thanks @nathankerr96 and congrats on your first contribution to CPython 🌮

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2018
@nathankerr96 @miss-islington
bpo-32720: Fixed the definition for width and precision in format min…
dd08873 
…i-language doc (pythonGH-5482)

Changed the definition of width and precision from "integer" to "digit+" in format mini-language doc.
(cherry picked from commit 8b5fa28)

Co-authored-by: nathankerr96 <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Feb 4, 2018

GH-5524 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2018
@nathankerr96 @miss-islington
bpo-32720: Fixed the definition for width and precision in format min…
a301070 
…i-language doc (pythonGH-5482)

Changed the definition of width and precision from "integer" to "digit+" in format mini-language doc.
(cherry picked from commit 8b5fa28)

Co-authored-by: nathankerr96 <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Feb 4, 2018

GH-5525 is a backport of this pull request to the 3.6 branch.

Mariatta pushed a commit that referenced this pull request Feb 4, 2018
@miss-islington @nathankerr96 @Mariatta
bpo-32720: Fixed the definition for width and precision in format min…
133514e 
…i-language doc (GH-5482) (GH-5524)

Changed the definition of width and precision from "integer" to "digit+" in format mini-language doc.
(cherry picked from commit 8b5fa28)

Co-authored-by: nathankerr96 <[email protected]>
Mariatta pushed a commit that referenced this pull request Feb 4, 2018
@miss-islington @nathankerr96 @Mariatta
bpo-32720: Fixed the definition for width and precision in format min…
3bd749b 
…i-language doc (GH-5482) (GH-5525)

Changed the definition of width and precision from "integer" to "digit+" in format mini-language doc.
(cherry picked from commit 8b5fa28)

Co-authored-by: nathankerr96 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nathankerr96 @the-knights-who-say-ni @csabella @miss-islington @Mariatta @bedevere-bot