-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-32765: Update configdialog docstrings to reflect new layout #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
terryjreedy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Additions look exactly right. Please add blurb with condensed title and text "Add new widgets to widget list." and I will merge.
In the future, please include first draft blurb, even with blank or dummy text, with original PR (unless not needed). It will be total less work.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. I'll be sure to include the blurb with my initial commit. |
|
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
|
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-5537 is a backport of this pull request to the 3.7 branch. |
…honGH-5529) Add new entries to the widget list. (cherry picked from commit 845d864) Co-authored-by: Cheryl Sabella <[email protected]>
…honGH-5529) Add new entries to the widget list. (cherry picked from commit 845d864) Co-authored-by: Cheryl Sabella <[email protected]>
|
GH-5538 is a backport of this pull request to the 3.6 branch. |
…5529) (GH-5537) Add new entries to the widget list. (cherry picked from commit 845d864) Co-authored-by: Cheryl Sabella <[email protected]>
…5529) (GH-5538) Add new entries to the widget list. (cherry picked from commit 845d864) Co-authored-by: Cheryl Sabella <[email protected]>
https://bugs.python.org/issue32765