Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Mar 8, 2017

bpo-29619: os.stat() and os.DirEntry.inodeo() now convert inode
(st_ino) using unsigned integers.

@vstinner vstinner added the type-bug An unexpected behavior, bug, or error label Mar 8, 2017
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Py_BUILD_ASSERT.

Should test sizeof(st->st_ino) <= sizeof(unsigned long long).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, I wrote my assertion backwards... Fixed, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sizeof(self->win32_file_index) <= sizeof(unsigned long long)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

bpo-29619: os.stat() and os.DirEntry.inodeo() now convert inode
(st_ino) using unsigned integers.
@vstinner vstinner merged commit 0f6d733 into python:master Mar 9, 2017
@vstinner vstinner deleted the unsigned_st_ino branch March 9, 2017 16:34
@vstinner
Copy link
Member Author

vstinner commented Mar 9, 2017

Ok, let's start with a backport to 3.6: #584

vstinner added a commit that referenced this pull request Mar 9, 2017
bpo-29619: os.stat() and os.DirEntry.inodeo() now convert inode
(st_ino) using unsigned integers.

(cherry picked from commit 0f6d733)
(Misc/NEWS conflict handled manually.)
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Bumps [celery](https://github.com/celery/celery) from 5.2.6 to 5.2.7.
- [Release notes](https://github.com/celery/celery/releases)
- [Changelog](https://github.com/celery/celery/blob/master/Changelog.rst)
- [Commits](celery/celery@v5.2.6...v5.2.7)

---
updated-dependencies:
- dependency-name: celery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants