Skip to content

bpo-33037: Skip sending/receiving after SSL transport closing #6044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asvetlov merged 2 commits into from
Mar 10, 2018
Merged

bpo-33037: Skip sending/receiving after SSL transport closing #6044

asvetlov merged 2 commits into from
Mar 10, 2018

Conversation

@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Mar 9, 2018 •
edited by bedevere-bot
Loading

@asvetlov asvetlov added type-bug An unexpected behavior, bug, or error topic-asyncio labels Mar 9, 2018
@asvetlov
Copy link
Contributor Author

asvetlov commented Mar 9, 2018

@1st1 please review.
The patch should be safe, it just skips raising unprocessed exception without adding a new behavior.
When using aiohttp I see the problem. It's reproduced not very often but on every long run I see reports about the problem in logs.

@asvetlov asvetlov merged commit 5e80a71 into python:master Mar 10, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Mar 10, 2018

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@asvetlov asvetlov deleted the async-ssl-closing branch March 10, 2018 15:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2018
@asvetlov @miss-islington
bpo-33037: Skip sending/receiving after SSL transport closing (python…
5bedc72 
…GH-6044)

* Skip write()/data_received() if sslpipe is destroyed
(cherry picked from commit 5e80a71)

Co-authored-by: Andrew Svetlov <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Mar 10, 2018

GH-6057 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Mar 10, 2018

Sorry, @asvetlov, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5e80a71ab67045fecec46573a1892e240b569ace 3.6

asvetlov added a commit to asvetlov/cpython that referenced this pull request Mar 10, 2018
@asvetlov
[3.6] bpo-33037: Skip sending/receiving after SSL transport closing (p…
ae9f707 
…ythonGH-6044)

* Skip write()/data_received() if sslpipe is destroyed.
(cherry picked from commit 5e80a71)
@bedevere-bot
Copy link

bedevere-bot commented Mar 10, 2018

GH-6058 is a backport of this pull request to the 3.6 branch.

asvetlov added a commit that referenced this pull request Mar 10, 2018
@miss-islington @asvetlov
bpo-33037: Skip sending/receiving after SSL transport closing (GH-6044)…
bf0d116 
… (GH-6057)

* Skip write()/data_received() if sslpipe is destroyed
(cherry picked from commit 5e80a71)

Co-authored-by: Andrew Svetlov <[email protected]>
asvetlov added a commit that referenced this pull request Mar 10, 2018
@asvetlov
[3.6] bpo-33037: Skip sending/receiving after SSL transport closing (G…
017e9fd 
…H-6044) (GH-6058)

* Skip write()/data_received() if sslpipe is destroyed.
(cherry picked from commit 5e80a71)
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
@asvetlov @jo2y
bpo-33037: Skip sending/receiving after SSL transport closing (python…
5806a85 
…GH-6044)

* Skip write()/data_received() if sslpipe is destroyed
@desbma desbma mentioned this pull request Mar 31, 2018
Closed
carlbordum added a commit to carlbordum/cpython that referenced this pull request Oct 5, 2020
@carlbordum
bpo-25292: asyncio ssl fail hard when writing to closed transport
4030502 
Before this patch, writing to a closed pipe will silently fail. This
issue is slightly related to bpo-33037/pythonGH-6044.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

Assignees

No one assigned

Labels

topic-asyncio type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asvetlov @miss-islington @bedevere-bot @1st1 @the-knights-who-say-ni