bpo-27428: Fix WindowsRegistryFinder documentation #6061
Conversation
Update documentation to clarify that WindowsRegistryFinder implement MetaPathFinder
Himanshu-Lakhara
force-pushed
the
fix-issue-27428
branch
from
897b50a to
51bf883
Compare
|
Thanks for the patch, @Himanshu-Lakhara ! I'll try to review this sometime in the next week or two. |
|
Thanks for reviewing @brettcannon and Sorry for delayed response. Since this is my first cpython PR and first PR on GitHub so I request you to please be thorough. I have previous experience contributing to open source project but not on GitHub. So It is possible that I might have missed something. Thanks again for your time. I'll try to be more responsive. |
|
@Himanshu-Lakhara no worries. I've been very busy as of late so I have not gotten around to doing a review anyway (although I cursory look seems good 😃 ). |
[no ci]
|
I tweaked the news entry, but otherwise LGTM! Once CI passes again I will merge this. |
|
Thanks @Himanshu-Lakhara for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-6205 is a backport of this pull request to the 3.7 branch. |
…e ABC (pythonGH-6061) (cherry picked from commit 5cbb841) Co-authored-by: Himanshu Lakhara <[email protected]>
…e ABC (pythonGH-6061) (cherry picked from commit 5cbb841) Co-authored-by: Himanshu Lakhara <[email protected]>
|
GH-6206 is a backport of this pull request to the 3.6 branch. |
…e ABC (GH-6061) (cherry picked from commit 5cbb841) Co-authored-by: Himanshu Lakhara <[email protected]>
…e ABC (GH-6061) (cherry picked from commit 5cbb841) Co-authored-by: Himanshu Lakhara <[email protected]>
|
Thanks @brettcannon for merging and tweaking news entry. It was my first PR to cpython and first PR on GitHub. Learned cpython workflow and Feeling more confident to take up some coding task. Thanks again for your guidance. |
5 participants
Update documentation to clarify WindowsRegistryFinder
implement MetaPathFinder
https://bugs.python.org/issue27428