bpo-33263: Fix FD leak in _SelectorSocketTransport #6450
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Under particular circumstances _SelectorSocketTransport can try to add a reader even the transport is already being closed. This can lead to FD leak and invalid stated of the following connections. Fixed the SelectorSocketTransport to add the reader only if the trasport is still active.
|
Out of curiosity, have you tried this with uvloop? |
|
@1st1 I can't reproduce the bug using uvloop, I guess it handles this situation fine. |
|
@drtyrsa Please let us know here when you have submitted a contributor agreement. There seem to be some problems right now with the PSF auto-receiving notifications about submitted agreements so we may need to notify them. |
|
@ned-deily I've signed and submitted it on 11th of April. I'll remove the label when I see an asterisk near my username in the bug tracker. |
|
We got your contributor agreement properly registered so this should now be good to go. |
|
@ned-deily Do I need to do something else to get it merged? Or it's going to happen automatically? |
|
GH-7022 is a backport of this pull request to the 3.7 branch. |
* bpo-33263 Fix FD leak in _SelectorSocketTransport. (pythonGH-6450) Under particular circumstances _SelectorSocketTransport can try to add a reader even the transport is already being closed. This can lead to FD leak and invalid stated of the following connections. Fixed the SelectorSocketTransport to add the reader only if the trasport is still active. (cherry picked from commit a84d0b3) Co-authored-by: Vlad Starostin <[email protected]>
|
Sorry, @drtyrsa and @asvetlov, I could not cleanly backport this to |
* bpo-33263 Fix FD leak in _SelectorSocketTransport. (GH-6450) Under particular circumstances _SelectorSocketTransport can try to add a reader even the transport is already being closed. This can lead to FD leak and invalid stated of the following connections. Fixed the SelectorSocketTransport to add the reader only if the trasport is still active. (cherry picked from commit a84d0b3) Co-authored-by: Vlad Starostin <[email protected]>
* bpo-33263 Fix FD leak in _SelectorSocketTransport. (pythonGH-6450) Under particular circumstances _SelectorSocketTransport can try to add a reader even the transport is already being closed. This can lead to FD leak and invalid stated of the following connections. Fixed the SelectorSocketTransport to add the reader only if the trasport is still active.. (cherry picked from commit a84d0b3)
|
GH-7025 is a backport of this pull request to the 3.6 branch. |
…7025) * bpo-33263 Fix FD leak in _SelectorSocketTransport. (GH-6450) Under particular circumstances _SelectorSocketTransport can try to add a reader even the transport is already being closed. This can lead to FD leak and invalid stated of the following connections. Fixed the SelectorSocketTransport to add the reader only if the trasport is still active.. (cherry picked from commit a84d0b3)
7 participants
Under particular circumstances _SelectorSocketTransport can try to add a reader
even the transport is already being closed. This can lead to FD leak and
invalid stated of the following connections. Fixed the SelectorSocketTransport
to add the reader only if the trasport is still active.
https://bugs.python.org/issue33263